Closed tomBeach closed 8 years ago
Thanks @tomBeach! 🙇 This is a much easier PR to review and merge than https://github.com/dcfemtech/hackforgood-waba-map/pull/66.
I added a bunch of line notes, mostly about console.log
statements - these shouldn't be in production code and should be removed before a PR. Console.log
statements can cause pages or websites not to load in older versions of IE - they will fail to load until you open up F12 Developer Tools, which an average user won't think of doing. When these are removed I can merge!
To Dos to tackle after we merge this PR - I'll convert each check box to a separate GitHub issue at Code for DC tonight.
console.log
errors with user-friendly errors in the UI - see https://github.com/dcfemtech/hackforgood-waba-map/issues/87@tomBeach addressed the remaining line notes in https://github.com/dcfemtech/hackforgood-waba-map/pull/78/commits/84fec6f6d40e538a40b63f3454bdc5983f77432d and cleaned up the file organization a little bit. I'm merging!
Added this branch and new files: index.html (replaces existing), script.js, css/styles.css.