search

dcfemtech / hackforgood-waba-map

DCFemTech Hack for Good 2016 - WABA Bike Map Project
MIT License
10 stars 9 forks source link

Changed to single quotes #84

Closed seongju closed 8 years ago

seongju commented 8 years ago

changed all the double quotes in site.js to single quotes

alulsh commented 8 years ago

First of all - thank you @seongju for a great first PR to this project! This was very helpful and not a particularly glamorous PR, but nonetheless important so that I can tackle https://github.com/dcfemtech/hackforgood-waba-map/issues/79 next without tests failing on master. Really appreciate what you did here to fix https://github.com/dcfemtech/hackforgood-waba-map/issues/80.

Just ran npm test and seeing some missing conversions to single quotes. I'm going to add another commit to this branch to fix these and merge if that's ok!

alexandraulsh@Bikini-Kill hackforgood-waba-map* single_quote $ npm test

> waba-bikemap@1.0.0 test /Users/alexandraulsh/hackforgood-waba-map
> eslint -c .eslintrc *.js

/Users/alexandraulsh/hackforgood-waba-map/site.js
   25:36  error  Strings must use singlequote  quotes
   26:15  error  Strings must use singlequote  quotes
  149:19  error  Strings must use singlequote  quotes
  232:29  error  Strings must use singlequote  quotes