fix: Lazy-load grant & grantRound metadata

dcgtc / dgrants

Decentralized Grant platform that implements quadratic funding.

GNU Affero General Public License v3.0

84 stars 39 forks source link

fix: Lazy-load grant & grantRound metadata #534

Closed gdixon closed 2 years ago

gdixon commented 2 years ago

This PR:

ensures that we are lazy-loading metadata and shows placeholder content while we're waiting for the metaPtr content to be fetched from ipfs (Closes: #510)
reduces the number of RPC calls we make on init
allows for metaPtr.protocol === 0 to default to placeholder images (Fixes: #532 && Fixes: #537)
fixes typings on cachedWhiteList (any -> LocalForageData)
only checkIsDeployed if were on dev (Fixes: #536)

gdixon commented 2 years ago

@gdixon thanks for tackling this! Testing out locally, I'm not seeing the intended effect play out practically. The page doesn't seem to load until all content is available, and in the network console, I see all the IPFS assets have fetched before the loading spinner disappears and the UI becomes available.

Could you try again with the changes I've just pushed? I had set a timeout around the fetchMetaPtrs during testing, and everything seemed okay, but you are right! It was still waiting on the resolution - the changes in f8dc6db should fix that!