search

dchaplinsky / german_registry_parser

Will the fun ever stop
3 stars 1 forks source link

Missing officer #13

Closed skenaja closed 5 years ago

skenaja commented 6 years ago

https://github.com/dchaplinsky/german_registry_parser/blob/76cff22e96849aa861974dd59f0f41683ab48d98/parsing_results/sample1/95335.json#L8

Rippegather, Dietmar, Mönchengladbach, *23.03.1957.

skenaja commented 5 years ago

Parser misses an officer from this notice: https://www.handelsregisterbekanntmachungen.de/skripte/hrb.php?rb_id=178404&land_abk=by

Schaaf, Christian Wilhelm, Egling, *23.04.1966

skenaja commented 5 years ago

Missed officer from this notice: https://www.handelsregisterbekanntmachungen.de/skripte/hrb.php?rb_id=1625989&land_abk=nw

Gronemeier, Manfred, Bielefeld, *17.12.1948

skenaja commented 5 years ago

https://www.handelsregisterbekanntmachungen.de/en/skripte/hrb.php?rb_id=907832&land_abk=nw

Missing officers (Only the first one has been parsed):

Geschäftsführer: Eckerle, Philipp, Aachen, *13.04.1980; Golubowitsch, Alexander, Erftstadt, *16.09.1976; Dr. Kessell, Andreas, Aachen, *29.12.1976

dchaplinsky commented 5 years ago

Please stop reporting it for a while :)

I'm about to push the fix.

On Wed, Feb 13, 2019 at 2:28 PM skenaja notifications@github.com wrote:

https://www.handelsregisterbekanntmachungen.de/en/skripte/hrb.php?rb_id=907832&land_abk=nw

Missing officers (Only the first one has been parsed):

Geschäftsführer: Eckerle, Philipp, Aachen, 13.04.1980; Golubowitsch, Alexander, Erftstadt, 16.09.1976; Dr. Kessell, Andreas, Aachen, *29.12.1976

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dchaplinsky/german_registry_parser/issues/13#issuecomment-463181463, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIAcvcVjM2GF7Z4O0rSuKoX4CzipnuQks5vNATsgaJpZM4V6QcS .

skenaja commented 5 years ago

lol - will leave you to it!

dchaplinsky commented 5 years ago

Okay, feel free to test. Some false positives should disappear as well.

I'd appreciate a proper QA, as this change is introducing new heuristic and has big impact.

On Wed, Feb 13, 2019 at 2:52 PM skenaja notifications@github.com wrote:

lol - will leave you to it!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dchaplinsky/german_registry_parser/issues/13#issuecomment-463188207, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIAchDl2AuZyHVWzc7Z_tyn6Qby6fE9ks5vNAqqgaJpZM4V6QcS .

skenaja commented 5 years ago

I carried out a lot of QA against sample2 on this one - Many of the missing officers are now present.

There were a few findings relating to officers from the QA which I'll raise in a new ticket.