search

dcharatan / flowmap

[3DV 2025] Code for "FlowMap: High-Quality Camera Poses, Intrinsics, and Depth via Gradient Descent" by Cameron Smith*, David Charatan*, Ayush Tewari, and Vincent Sitzmann
https://cameronosmith.github.io/flowmap/
MIT License
893 stars 87 forks source link

A potential coding bug ? #40

Closed leo-frank closed 5 months ago

leo-frank commented 5 months ago

In pick rgb colors, you directly use xy to pick colors from images. But in fact, xy are in range [0, 1], I think you should use 2*xy-1.

dcharatan commented 5 months ago

Yes, this is definitely a bug. Thank you for discovering this! I've pushed a commit that should fix it.