dcherednik / atracdenc

Dirty implementation of ATRAC1, ATRAC3 encoder
GNU Lesser General Public License v2.1
58 stars 14 forks source link

Fix CMake build file generation error and add a missing <cstdint> header #33

Closed SatoFoo closed 10 months ago

SatoFoo commented 10 months ago

This pull request fixes the following CMake error, except for the deprecation warning.

CMake Deprecation Warning at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Error at /usr/share/cmake/Modules/Internal/CheckFlagCommonConfig.cmake:61 (message):
  check_compiler_flag: CXX: needs to be enabled before use.
Call Stack (most recent call first):
  /usr/share/cmake/Modules/Internal/CheckCompilerFlag.cmake:13 (cmake_check_flag_common_init)
  /usr/share/cmake/Modules/CheckCXXCompilerFlag.cmake:34 (cmake_check_compiler_flag)
  CMakeLists.txt:18 (check_cxx_compiler_flag)
  CMakeLists.txt:26 (enable_cxx_compiler_flag_if_supported)

CMake Error at /usr/share/cmake/Modules/Internal/CheckFlagCommonConfig.cmake:61 (message):
  check_compiler_flag: CXX: needs to be enabled before use.
Call Stack (most recent call first):
  /usr/share/cmake/Modules/Internal/CheckCompilerFlag.cmake:13 (cmake_check_flag_common_init)
  /usr/share/cmake/Modules/CheckCXXCompilerFlag.cmake:34 (cmake_check_compiler_flag)
  CMakeLists.txt:18 (check_cxx_compiler_flag)
  CMakeLists.txt:27 (enable_cxx_compiler_flag_if_supported)

-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found LIBSNDFILE: /usr/include
-- Configuring incomplete, errors occurred!

By the way, the original bitstream/bitstream.cpp file was missing <cstdint> header.