dchest / cryptopass

Chrome extension: password generator from master key using PBKDF2 with SHA-256.
https://chrome.google.com/webstore/detail/hegbhhpocfhlnjmemkibgibljklhlfco
18 stars 9 forks source link

Skip buttons when filling login/password #7

Closed mgorny closed 9 years ago

mgorny commented 9 years ago

Some login forms have submits/buttons named 'login'. Avoid replacing the values (labels) of those buttons with the login.

Happens for example on https://www.njumobile.pl/logowanie

dchest commented 9 years ago

Maybe it's better to include the types we're looking for rather than exclude the ones we don't like? E.g. text and email?

mgorny commented 9 years ago

I don't mind either way. I choose opt-out model because HTML5 introduces a lot of new input types, and I didn't want the script to break again when more specific types are introduced.

dchest commented 9 years ago

That's fine, because if they introduce type="also-send-all-the-info-to-government", we won't fill it :-)

mgorny commented 9 years ago

Updated.

dchest commented 9 years ago

Thank you! Merged and uploaded to Chrome Web Store.

mgorny commented 9 years ago

Thanks for the quick response. I have a few more improvement ideas, and I'll try to implement them when I find some free time.

dchest commented 9 years ago

Great, thanks.