dchest / scrypt-async-js

Fast "async" scrypt implementation in JavaScript
http://dchest.github.io/scrypt-async-js/
BSD 2-Clause "Simplified" License
139 stars 26 forks source link

Implement CI Testing with Saucelabs #11

Closed evilaliv3 closed 9 years ago

evilaliv3 commented 9 years ago

This pull request implement support for testing scrypt-async-js in the cloud among multiple user browsers by means of SauceLabs.com.

@dchest: this cloud service is free for opensource projects and would be valuable to add it for scrpt-async so to properly validate the implementation against browsers setups.

Image used in the badge: https://saucelabs.com/browser-matrix/evilaliv3.svg Readme.md badge viewable at: https://github.com/evilaliv3/scrypt-async-js/tree/feature/saucelabs

p.s. i've also removed the grunt-string-replace library that i included wrongly in previowu pull request

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 97.89% when pulling a2fa68f2293ef452a96008620e2c01d01f0a8941 on evilaliv3:feature/saucelabs into 77d510b4cc19aa006546388bfcd2f34ca87782df on dchest:master.

dchest commented 9 years ago

Awesome, thanks! Do you think this can be fixed: https://travis-ci.org/dchest/scrypt-async-js/jobs/61231467#L326 ? Is this a timeout?

evilaliv3 commented 9 years ago

the internal code is the following:

        if (attempts === 0) {
          var errorMessage = "After trying " + me.statusCheckAttempts +
                             " times with a delay of " + me.pollInterval +
                             "s, this job never reached 'complete' status.";
          throw new Error(errorMessage);
        } else {
          return Q
            .delay(me.pollInterval)
            .then(fetch.bind(this, retries));
        }

so if i'm not wrong reading from https://github.com/axemclion/grunt-saucelabs the relevant wariables should be:

pollInterval: Number of milliseconds between each retry to see if a test is completed or not (default: 2000). Optional

statusCheckAttempts: Number of times to attempt to see if a test is completed or not (default: 90). Effectively, your tests have statusCheckAttempts * pollInterval seconds to complete (Thus, 180s by default). Set to -1 to try foreve
dchest commented 9 years ago

@evilaliv3 will you set it or should I try?

evilaliv3 commented 9 years ago

ah! you were waiting for me!

sorry let me do it now.

dchest commented 9 years ago

No hurry, I wasn't actually waiting for anything, was just busy with other things :-) Would be good if the CI build passes before I merge.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 97.89% when pulling 68fce80edde9b6a3811046128fc300258ca91b3f on evilaliv3:feature/saucelabs into 77d510b4cc19aa006546388bfcd2f34ca87782df on dchest:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 97.89% when pulling f0a19299a1d1e1b2233f61d9ac2f0e0e14a71a3a on evilaliv3:feature/saucelabs into 77d510b4cc19aa006546388bfcd2f34ca87782df on dchest:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 97.89% when pulling d54fcaa1303e341eb72253def08c7a15fe868985 on evilaliv3:feature/saucelabs into 77d510b4cc19aa006546388bfcd2f34ca87782df on dchest:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 97.89% when pulling c96fd304cb21c6942421fab51bef60d7c87f0450 on evilaliv3:feature/saucelabs into 77d510b4cc19aa006546388bfcd2f34ca87782df on dchest:master.

evilaliv3 commented 9 years ago

Ok @dchest i finally succeded. i removed the specific test you put against node 0.10, 0.12 and iojs and i simply written "stable". iojs was having issues to run the instrumented code. eventually we should differentiate but i think that now that we have real browser tests it is not required that we test against node as the libray is thought for the browsers.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 97.89% when pulling e0166075ec0b8a9fb5f4ad56fee6bc9158834034 on evilaliv3:feature/saucelabs into 77d510b4cc19aa006546388bfcd2f34ca87782df on dchest:master.

dchest commented 9 years ago

Yay, thank you!