Closed evilaliv3 closed 8 years ago
Thanks, I'll take a look at it a bit later. Can this "function complexity" and "too many statements" noise be turned off, because this stuff is the result of optimizing the implementation.
Here are links in order to evaluate the capabilities:
https://github.com/evilaliv3/scrypt-async-js/tree/codeclimate https://codeclimate.com/github/evilaliv3/scrypt-async-js/scrypt-async.js
answering your question yes @dchest , codeclimate allow very easily to configure ignore statements:
Hmm, all of these "issues" look useless to me right now. I'm happy that it runs ESLint, although we can put it into the "build" step instead of calling their APIs.
Yes i agree that nothing critical is here but the great thing of integrating the tracker is that you can enable callbacks on the pull request and spot automagically the various code issues without having to manually run the linter.
In addition is useful to improve the trust of user in the library to show them that all is coded properly.
OK, good arguments.
This pull requests:
since the integration it will be possible to have the following outputs:
it will be easy then fix issues in the code related to not standard/interoperable syntaxes
After integration the codeclimate token should be replaced with a token specific for the dchest/scrypt-async-js to be taken loggin onto https://codeclimate.com/dashboard