dchest / scrypt-async-js

Fast "async" scrypt implementation in JavaScript
http://dchest.github.io/scrypt-async-js/
BSD 2-Clause "Simplified" License
140 stars 26 forks source link

Address main allocation issues #26

Closed evilaliv3 closed 8 years ago

evilaliv3 commented 8 years ago

This pull requests address the main allocation issues as reported in https://github.com/dchest/scrypt-async-js/issues/25

The patch simply move some variables from the local to the global scope; Maybe that some variables could be renamed in order to improve code readability.

Max13 commented 8 years ago

@evilaliv3 Is this PR still needed? Or maybe forgotten because already implemented?

evilaliv3 commented 8 years ago

Still needed even if the fix is minor

Max13 commented 8 years ago

I think I will fork it and apply your PR, thx