search

dchest / tweetnacl-js

Port of TweetNaCl cryptographic library to JavaScript
https://tweetnacl.js.org
The Unlicense
1.75k stars 292 forks source link

README: add note about performance in Jest tests #221

Closed Valodim closed 2 years ago

Valodim commented 2 years ago

tweetnacl-js is noticeably slow in Jest tests, which can be fixed by simply configuring the test vm to include the Math object. Took us a while to figure out, maybe this will save someone else the trip :)

dchest commented 2 years ago

Hah! Thanks, but since this pretty specific to a particular library, I think it belongs in the wiki rather than README. Could you please add it there? (I think it should be open for editing but if not, please let me know).

CMEONE commented 2 years ago

I agree, this is pretty specific and should be put in the wiki. I'll go ahead and create a section there.

CMEONE commented 2 years ago

I added this note to the wiki under the Performance in Jest page. @Valodim if this page looks good, I think this issue can be closed @dchest

Valodim commented 2 years ago

lgtm. thanks :+1: