search

dchesterman / ivyidea

Automatically exported from code.google.com/p/ivyidea
0 stars 0 forks source link

Ignore dependency if ArtifactDownloadReport.downloadStatus == DownloadStatus.NO #106

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The problem is on internal complex config using internal corporate repository.

Expected output: dependencies resolved by ant are the same as by Idea 
Actual output: there are some differences.

Plugin version - 1.0.3 on Windows 7 Enterprise x64

I debugge in org.clarent.ivyidea.resolve.DependencyResolver:107 by adding 
breakpoint on unexpected jar name.
When breakpoing is invoked i see in artifactDownloadReport.downloadStatus value 
"no". The comment for this status from apache-ivy-2.30-rc2.jar is

/**
     * means that download was not required
     */
    public static final DownloadStatus NO = new DownloadStatus("no");

So i propose add in DependencyResolver line 108 check of this Status, e.g.

if (externalDependency != null && artifactDownloadReport.getDownloadStatus()!= 
DownloadStatus.NO) {
...

Original issue reported on code.google.com by mukhamet...@gmail.com on 22 Jan 2013 at 3:57

GoogleCodeExporter commented 9 years ago 
Sorry, had more time to debug and found that reason for extra dependencies for 
"test" scope.
Posted question for idea http://devnet.jetbrains.net/thread/441296

Original comment by mukhamet...@gmail.com on 22 Jan 2013 at 6:06

GoogleCodeExporter commented 9 years ago 
sorry, what exactly is the problem here?
or can we close this issue?

Original comment by maarten....@cumulus.uzleuven.be on 25 Jan 2013 at 10:07

GoogleCodeExporter commented 9 years ago 
yes, you can close the issue
my problem is that under my configuration I get two slf4j jars 
slf4j-log4j12-1.5.6.jar and slf4j-log4j12-1.7.1.jar and my test did run only on 
manually removing old slf4j-log4j12-1.5.6.jar. I guess this is eviction bug of 
ivy for different scopes. So my proposition was to separate test and compile 
scope class paths.

Original comment by mukhamet...@gmail.com on 30 Jan 2013 at 10:53

Attachments:

GoogleCodeExporter commented 9 years ago 
ok, issue closed

Original comment by maarten....@gmail.com on 18 Feb 2013 at 9:36