search

dchristl / esp32_nat_router_extended

a simple ESP32 NAT Router with some additional features
292 stars 54 forks source link

FR: Editable GPIO Pin? #103

Open theStanister opened 8 months ago

theStanister commented 8 months ago

Hi, great fork! Very useful indeed!

I have a feature request, looks like GPIO's been hardcoded to pin 2... // On board LED #define BLINK_GPIO 2

For whatever reason, my ESP32's LED is on PIN 8 (and I'm assuming there might be other nonstandard pins).

any chance of adding a config in the advanced menu under Blink LED to specify PIN# to override this? I would've done this myself in my local copy but I only have Arduino IDE and i havent got a VSCode build environment set up so that itself might take me a while. Thanks heaps!

dchristl commented 8 months ago

Hello @theStanister ,

thank you for your kind words.

The problem with your request is that there are too many boards (even the default boards ESP32, S2, C3 differ), and I'm trying to keep the codebase largely consistent.

any chance of adding a config in the advanced menu under Blink LED to specify PIN# to override this?

I will think about it.

I would've done this myself in my local copy but I only have Arduino IDE and i havent got a VSCode build environment set up so that itself might take me a while. Thanks heaps!

It is really insanely easy to set up the project with the documentation. The longest part is probably the download.

Kind Regards, Danny