Closed phuong3030 closed 9 years ago
Can you deploy the changes?
I have updated new code to server.
The in-page field should render an additional field to input the id or class. Currently there is only a label.
Hey Phuong,
I don't think you understood what I meant. There should be an Extra field. Since we need to give it a label, the first field should be the label, and the Additional field will be the class or id.
Ah i will add an extra field in inpage to enter id/class. I will fix it today.
https://github.com/phuong3030/QuoteManager/pull/8 and I updated new code to server.
I pushed up some changes to use in the in-page field to collect the product information which was my original intention. I commented out the parts where product names and options were rendered originally.
The issue that I am running into now is that the title for instance is not contained within a tag with a class or an id but as a child h1 tag of an identifiable id. We should think about creating some flexibility to grab text within tags that aren't within the grasp of the current function we are using to grab the data.
Also, the product option fields are collected, but when changes are made to the selections, they are not reflected. We should be able to account for those changes as well.
Feature: https://github.com/boopis/QuoteManager/pull/34 Hotfix: https://github.com/boopis/QuoteManager/pull/35
I think i will find string in user's page and search few neighbor elements. But we should show up product information by using input field, if any suggestion is not correct, user can fix it manually.
User will use 'in-page' form field to enter their element id / class. We will use the value get from this field to search in user page.
Quote manager new form page: Label of this field is use for search variant option in shopify product page.
Quote manager show form page: This in-page field will show text input, user use it to enter variant option value and submit to create new request.
Shopify product page: This label of this in-page field use for search variant value. (issue Merge JS & Form Requests into One Request will resolve this function)