dchun / QuoteManager

Saas App for Managing Quotes and getting paid
https://quotemanager.boopis.com
0 stars 0 forks source link

Notification Email Modification #254

Open dchun opened 9 years ago

dchun commented 9 years ago

Add reply to field to the email for the user submitting the form, and make the "Dear #{user.name}" a smaller font size. And if the name isn't present, remove the dear line entirely.

Also, add a link in the footer of all emails that says "Powered by QuoteManager" with a link.

And is there any way to also cc an account in qm to change the state of the request to something like "responded"?

phuong3030 commented 9 years ago

Modify email notification: https://github.com/boopis/QuoteManager/pull/256

phuong3030 commented 9 years ago

And is there any way to also cc an account in qm to change the state of the request to something like "responded"? Can you add more information?

dchun commented 9 years ago

This might be a complex feature to add but I was thinking we needed some way of making the response easier when the user doesn't want to necessarily create a quote.

You can view a tutorial as an example here: https://drive.google.com/a/boopis.com/file/d/0B-KrUSVQ_nEna0RyaUVNSEZkZms/view?usp=sharing

We would need to parse the email and ensure a value is present to know which request resource to update and create an exception is the information needed isn't present and just ignore the incoming email.

How to define what email to respond to, I will leave up to you to figure out and design. A way might be to accept and match incoming emails from the user that matches the email "from" field and matching the subject id as the resource. But that is vulnerable to email spoofing that can be generated by any server so you would need to figure out a secure way to implement this feature.

phuong3030 commented 9 years ago

We added mailman gem to this project. You mean user can send email to server or cc to server and server will parse the email content to update the state of request?

If so, we need to define the form of an email. And for security issue, can we add the token to the email content?

phuong3030 commented 9 years ago

This issue will be implemented by some steps:

phuong3030 commented 9 years ago

https://github.com/phuong3030/QuoteManager/commit/bedaa5a1ae675114cd8f4164cf51f5ed50fc5bf8

phuong3030 commented 9 years ago

https://github.com/boopis/QuoteManager/pull/261

dchun commented 9 years ago

The reply-to field still doesn't exist. There should be an email that is sent to the server to change the state of the request. Also the "powered by" footer should be in the thank you email to the person submitting the request. Not the user of our app. They already know of our services. The reason we are adding the powered by field is for marketing purposes.

phuong3030 commented 9 years ago

I forgot to update new code to server.

phuong3030 commented 9 years ago

https://github.com/boopis/QuoteManager/pull/266

dchun commented 9 years ago

I meant when the owner clicks the reply button in the email. Not some form to be included.

phuong3030 commented 9 years ago

https://github.com/boopis/QuoteManager/pull/267