search

dciabrin / ngdevkit

Open source development for Neo-Geo
GNU Lesser General Public License v3.0
262 stars 26 forks source link

Building the devkit with gcc-10 doesn't work #36

Closed dciabrin closed 4 years ago

dciabrin commented 4 years ago

As detailed in the changelog for GCC 10 [1], gcc now defaults to -fno-common:

In C, global variables with multiple tentative definitions now result in linker errors. With -fcommon such definitions are silently merged during linking

Practically for ngdevkit, this change exposed various invalid C declarations [2], so the devkit fails to compile successfully.

[1] https://gcc.gnu.org/gcc-10/changes.html [2] at least in gngeo last time I checked

dciabrin commented 4 years ago

I verified on my Fedora that ngdevkit-toolchain builds with gcc-10, so I think we can close this issue now that gngeo and emudbg have been updated.