dciccale / grunt-processhtml

Process html files at build time to modify them depending on the release environment
MIT License
407 stars 30 forks source link

Support for media="print" #58

Closed atimmer closed 9 years ago

atimmer commented 10 years ago

Currently media="print" is completely stripped and there is no way to include it.

Can you give a direction to how you would prefer this to be implemented? ea. In the HTML as an extra attribute, or as an option in the Gruntfile, or as auto detect the media attribute of the containing link tags. Then I can spin up a pull request.

dciccale commented 10 years ago

This is a missing feature, please be free to contribute.

On Thu, Oct 23, 2014 at 10:52 AM, Anton Timmermans <notifications@github.com

wrote:

Currently media="print" is completely stripped and there is no way to include it.

Can you give a direction to how you would prefer this to be implemented? Then I can spin up a pull request.

— Reply to this email directly or view it on GitHub https://github.com/dciccale/grunt-processhtml/issues/58.

atimmer commented 10 years ago

I know it is missing, but which of those options do you prefer? I don't know what is best for the project.

dciccale commented 10 years ago

Ok I will check in detail this weekend and see the best choice On 23 Oct 2014 11:49, "Anton Timmermans" notifications@github.com wrote:

I know it is missing, but which of those options do you prefer? I don't know what is best for the project.

— Reply to this email directly or view it on GitHub https://github.com/dciccale/grunt-processhtml/issues/58#issuecomment-60216050 .

dciccale commented 9 years ago

Related issue for supporting attributes https://github.com/dciccale/grunt-processhtml/issues/34

dciccale commented 9 years ago

Now by using [attr] blocktype you can achieve this.