search

dciccale / grunt-processhtml

Process html files at build time to modify them depending on the release environment
MIT License
407 stars 30 forks source link

update dependencies #97

Closed marcobiedermann closed 8 years ago

marcobiedermann commented 8 years ago

Update all dependencies fix #96

dciccale commented 8 years ago

@marcobiedermann why is this failing?

marcobiedermann commented 8 years ago

@dciccale I think it failed because of an outdated Node version. I merged the changes on master in it and all tests work fine with the newly set up versions 5.1, 4.4 and 0.12

dciccale commented 8 years ago

maybe there are breaking changes on grunt 1+.. it could make sense releasing a major version, need to do more research

marcobiedermann commented 8 years ago

@dciccale

Be advised Grunt 1.0.0 will no longer support Node.js v0.8.

Hmm … The previous tests were run against Node.js v0.10, so this might not be the issue

dciccale commented 8 years ago

i meant more of inside grunt APIs.. methods, etc, but I guess that if tests pass we are good to go..