search

dcjones / quip

Compressing next-generation sequencing data with extreme prejudice.
http://www.cs.washington.edu/homes/dcjones/quip/
BSD 3-Clause "New" or "Revised" License
78 stars 10 forks source link

Buffer Overflow. Easy fix. #19

Closed simnim closed 11 years ago

simnim commented 11 years ago

Line 441: out_fn = malloc_or_die(fnlen + 1);

Change it to: out_fn = malloc_or_die(fnlen + 4);

Since you write 3 extra bytes off the end of the buffer: ".qp" (aside from the '\0') when you compress a fastq file.

dcjones commented 11 years ago

Thanks very much for that!