dcm4che / dcm4chee-arc-light

DICOM Archive J2EE application
439 stars 242 forks source link

UI Navigation -> Studies : View DICOM Object on instance level missing for users configured with 'user' role #2747

Closed Milzor closed 4 years ago

Milzor commented 4 years ago

Describe the bug User role doesn't get access to view dicom image in dcm4chee-arc-light UI. I followed the steps on https://github.com/dcm4che/dcm4chee-arc-light/wiki/User-Role-Access-to-Viewer, but once a regular user logs in it doesn't show the View DICOM Object in

To Reproduce Steps to reproduce the behavior:

  1. Follow steps https://github.com/dcm4che/dcm4chee-arc-light/wiki/User-Role-Access-to-Viewer
  2. Login as regular user.
  3. Open any study.
  4. Click the 3 dots.
  5. Small popup doesn't show View DICOM Object

Expected behavior The popup should show View DICOM Object

Screenshots image image

Desktop (please complete the following information):

Additional context Logged in user has the role user and user role is added to the UI Configuration permissions. See screenshot. Running docker images:

vrindanayak commented 4 years ago

@Milzor : Issue is not related to the UI permission Action - Studies - Open Viewer - FYI, this UI permission relates to Invoke Image Display feature used in conjunction with Weasis Viewer Integration

I've rectified the issue title to clearly indicate the bug.

image

Thank you for reporting the issue!

shral commented 4 years ago

First of all, I would strongly recommend not to use the user-role "user" because according to our definition of the Keycloak user of the UI every UI-user should have that role (you can not log in into the UI if your username doesn't have the role "user"). That means if you give some permission to the role "user" every other user will have that permission!!!

Regarding the issue: I don't see any bug in the UI, I only see a configuration confusion, namely: The button with the Hover text View DICOM Object is controlled by the permission action action-studies-download (and not by action-studies-viewer as you tried) and the Action Parameter visible (Viewing an object is technically the same as downloading)

image

What you configured is the permission to open a Viewer. To see the open-viewer button you have to fulfill two conditions, to have the permission (what you did) and to configure to that web-application (what you selected to get the studies) the viewer URLs (see the second image)):

image

image