Code Lab Feedback - Githubissues

dcmalburg commented 9 years ago

Hey @chrisvfritz, can you take a look at this? It's hosted here and meets the following project criteria:

[x] include at least one instance of each of the following properties: margin, padding, border, color, background, font-size, line-height (properties must have a visible effect)
[x] return no errors (warnings are OK) when the HTML document is uploaded to the W3C Markup Validation Service
[x] return no errors or warnings when contents of your CSS are pasted into CSS Lint

chrisvfritz commented 9 years ago

The styles are looking very nice! And you even used a special selector to change the color of visited links! :tada: There are two issues I'm seeing, but after those are fixed, it should be ready for the shipit squirrel!

First, I would rename Resume.html to index.html. That's a special name that will help browsers use the file as your homepage. Otherwise, nothing would show up on your homepage and you'd have to visit silly-name.surge.sh/Resume.html to see your site.

The second is that the link to where the site is hosted should actually be a surge link. Try making the change above, then follow the Next steps for the project to get your updated code on GitHub and to publish this site with surge. Afterwards, can you paste the surge URL here so I can check it out?

dcmalburg commented 9 years ago

http://spongebobs-css.surge.sh updated surge url!

chrisvfritz commented 9 years ago

Magnifique! :shipit:

dcmalburg / codelab-css-intro

Code Lab Feedback #1