Code Lab Feedback - Githubissues

dcmalburg / codelab-js-intro

https://github.com

0 stars 0 forks source link

Code Lab Feedback #1

Open dcmalburg opened 8 years ago

dcmalburg commented 8 years ago

Hey @chrisvfritz, can you take a look at this? It's hosted here and meets the following project criteria:

[x] Include a button that will display a silly, but tasteful joke in an alert when clicked
[x] Return no errors (warnings are OK) when the HTML is uploaded to the W3C Markup Validation Service
[x] Return no errors or warnings when the JavaScript is pasted into JavaScript Lint

chrisvfritz commented 8 years ago

It looks like the link to where the site is hosted is pointing to this repository, while it should actually be a surge link to a live version of the site. Make sure you've followed all of the Next Steps for the project to ensure your latest code is on GitHub and your site is published with surge. Afterwards, can you paste the surge URL here so I can check it out?

dcmalburg commented 8 years ago

http://spongebobs-css.surge.sh updated surge url!

chrisvfritz commented 8 years ago

Looks good to me! :shipit: