dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
299 stars 112 forks source link

fix(IDC-2252): Update getsegmentindex to use frame index #179

Closed igoroctaviano closed 3 years ago

igoroctaviano commented 3 years ago

Fixes the issue: https://github.com/dcmjs-org/dcmjs/pull/166 (tested using segment example)

Updates getSegmentIndex method with new fallback list:

pieper commented 3 years ago

LGTM 👍

We might need to do a commit with a semantic prefix like fix(seg) to trigger a minor release.

igoroctaviano commented 3 years ago

LGTM 👍

We might need to do a commit with a semantic prefix like fix(seg) to trigger a minor release.

Youre right, missed it, this one has a semantic commit in it. https://github.com/dcmjs-org/dcmjs/pull/180

ohif-bot commented 3 years ago

:tada: This PR is included in version 0.18.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: