Enable a force write option for files with abnormal VRs #162

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation

https://dcmjs.netlify.com/

MIT License

299 stars 112 forks source link

Enable a force write option for files with abnormal VRs #162 #186

Closed WoonchanCho closed 3 years ago

WoonchanCho commented 3 years ago

Hi @pieper or maintainers, This is an improvement to add a force write option as discussed in #162. @johndgiese 's team is busy doing other priorities, so I worked on this. Hopefully they also like this change.

The decedents of ValueRepresentation has different parameter list. So, I had to align a bit to add write option Feel free to give me your thought and push if it looks good.

add allowInvalidVRLength (false by default) in the write options
add a test case for testing this option

pieper commented 3 years ago

Looks good to me. @johndgiese and @ejcurtis any comments?

johndgiese commented 3 years ago

I took a quick look and the changes look good to me too.

pieper commented 3 years ago

Thanks @johndgiese

Okay, I'll merge with a new commit prefix to trigger a minor release.

ohif-bot commented 3 years ago

:tada: This PR is included in version 0.18.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: