Fix example - Githubissues

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation

https://dcmjs.netlify.com/

MIT License

299 stars 112 forks source link

Fix example #187

Closed Punzo closed 3 years ago

Punzo commented 3 years ago

Fix https://github.com/dcmjs-org/dcmjs/issues/184

@pieper in this PR I fix the example and add additional checks.

Please let me know what do you think of PR inline comments, if the inline comments are not clear we can have a videocall or discuss it at the next IDC-OIHF meeting.
The data from the example (Display DICOM Segmentation IOD) do not satisfy assumption 1.
Data that I have from IDC satisfy both Assumption 1 and 2.

@gangaramstyle this include fix from https://github.com/dcmjs-org/dcmjs/pull/185 as well

gangaramstyle commented 3 years ago

Other than my comment on importing from build vs ../js/* it looks great to me! Thanks @Punzo

Punzo commented 3 years ago

@pieper thanks for the review. I have replied to the comments

Punzo commented 3 years ago

@igoroctaviano comments applied, a part https://github.com/dcmjs-org/dcmjs/pull/187#discussion_r589452632 I would say we can do that in a separate PR.

P.S. for Steve :

Generally looks good and we want the seg in idc fixed. Let me know what you think of my comments.

https://github.com/dcmjs-org/dcmjs/pull/183 from Igor already fixed the seg in idc. This PR adds more checks and make it working the examples. Please feel free to squash and merge if you think it is ready.

ohif-bot commented 3 years ago

:tada: This PR is included in version 0.18.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: