search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
293 stars 112 forks source link

fix: 🐛 ignore frames without SourceImageSequence information when loading a segmentation #198

Closed Punzo closed 3 years ago

Punzo commented 3 years ago

IDC issue: https://github.com/OHIF/Viewers/issues/2345

Two main limitations are generated by the current cornerstone approach (segmentation geometry has to fit the one of the source images):

1) we can't have out of plane frames; 2) we can't have segmentation frames with different Columns and Rows attributes respect to the source frames.

in this PR we add checks to detect such data and abort the laoding.

Relevant IDC datasets:

Punzo commented 3 years ago

@pieper @igoroctaviano can you review and merge this please?

ohif-bot commented 3 years ago

:tada: This PR is included in version 0.18.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: