search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
298 stars 112 forks source link

#204 fix: can't read an encapsulated frame whose size is greater than fragment size #205

Closed codepage949 closed 3 years ago

pieper commented 3 years ago

Thanks for contributing 👍

From what I can tell this looks like good fix. @jmhmd looks like this touches on things you added, can you review?

Nitpick: For testing I've been trying to keep the dicom files themselves as binary release assets in https://github.com/dcmjs-org/data rather then putting them in the repo. If you look at some of the other tests you'll find they use downloadToFile which is pretty easy. I notice now that a couple of other .dcm files slipped into the testing directory but I'd like to get rid of those even though they are pretty small.

codepage949 commented 3 years ago

@pieper how to join the repo(https://github.com/dcmjs-org/data)?

ohif-bot commented 3 years ago

:tada: This PR is included in version 0.18.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: