search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
298 stars 112 forks source link

Potentially incorrect assumption while parsing SEG #232

Closed fedorov closed 2 years ago

fedorov commented 2 years ago

While debugging an issue with a SEG not being shown in OHIF Viewer, I came across this code:

https://github.com/dcmjs-org/dcmjs/blob/44850b3ac59fab774c841f5738ca1cc874d18eb8/src/adapters/Cornerstone/Segmentation_4X.js#L642-L656

If I understand it correctly, there is an assumption that is made that perhaps number of frames within a segmentation should be the same for all segments. If this is the case, it is not a correct assumption. As an example, it is valid to have a CT series with 200 slices, and a segmentation that has, say, 3 segments, where 1 segment has 3 frames, and the other two are defined in one frame each.

@Punzo any comments? I see those lines were added by you. No urgency with this of course - can discuss sometime after the holidays.

ohif-bot commented 2 years ago

:tada: This issue has been resolved in version 0.19.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: