dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
292 stars 111 forks source link

fix: 🐛 IDC2733: find segmentations reference source image Ids #253

Closed Punzo closed 2 years ago

Punzo commented 2 years ago

Improve find logic for segmentations reference source image Ids as discussed in https://github.com/OHIF/Viewers/issues/2733.

To find the refence source image id now we do: 1) we filter out source series with the segmentation ReferencedSeriesSequence.SeriesInstanceUID 2) we filter out source instances with the segmentation FrameOfReferenceUID 3) we filter out source instances with the segmentation PerFrameFunctionalGroup.PlanePositionSequence.ImagePositionPatient (within a tolerance)

If a source instance is not found for the segmentation frame, we do a last try using simply the segmentation frame ReferencedSOPInstanceUID

Punzo commented 2 years ago

@pieper could you please review? Thanks

ohif-bot commented 2 years ago

:tada: This PR is included in version 0.19.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: