search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
292 stars 111 forks source link

Fix the circle adapter to prevent writing undefined #266

Closed wayfarer3130 closed 2 years ago

wayfarer3130 commented 2 years ago

The circle adapter was writing undefined for the area and diameter.

wayfarer3130 commented 2 years ago

@sedghi - could you respond to Steve please about this issue? It is just an adapter that works for cornerstone 2d circle roi, as the previous one had some bugs in it.

sedghi commented 2 years ago

@sedghi - could you respond to Steve please about this issue? It is just an adapter that works for cornerstone 2d circle roi, as the previous one had some bugs in it.

I would ask @JamesAPetts since he knows better this space, my only comment is that why we are hard coding radius: 5

JamesAPetts commented 2 years ago

LGTM. I agree with setting the values 0 if we don't know them, its the only honest thing to do.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 0.22.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: