search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
292 stars 111 forks source link

fix(dcmjs):Make the conceptCodeSequence generateReport a proxy #274

Closed wayfarer3130 closed 2 years ago

wayfarer3130 commented 2 years ago

The conceptCodeSequence generated by the generateReport is supposed to be consistent with that generated by parsing, but because of the proxy it wasn't consistent, so this change makes it consistent

@sedghi - could you please check this branch out and see if it fixes your problem? FIxes #273

pieper commented 2 years ago

@wayfarer3130 can you resolve the conflicts?

wayfarer3130 commented 2 years ago

Will resolve them after I get over covid - too out of it to fix anything right now.

Bill

On Mon, 13 Jun 2022 at 12:37, Steve Pieper @.***> wrote:

@wayfarer3130 https://github.com/wayfarer3130 can you resolve the conflicts?

— Reply to this email directly, view it on GitHub https://github.com/dcmjs-org/dcmjs/pull/274#issuecomment-1154143251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGT56XKARQWR4C26RLNNTSTVO5PULANCNFSM5YHGU5GQ . You are receiving this because you were mentioned.Message ID: @.***>

pieper commented 2 years ago

after I get over covid

Oof - get well soon!

wayfarer3130 commented 2 years ago

@sedghi - I made one more change you requested - it still isn't used universally, but I'd rather have several small issues than one that fixes mroe things than needed. Let me know if it still works for you. Also updated the PR with the latest merges.

sedghi commented 2 years ago

@wayfarer3130 This is great, yes it solves my issue