dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
292 stars 111 forks source link

Update ESLint & Prettier. Modernize configs. Run Prettier. #275

Closed richard-viney closed 2 years ago

richard-viney commented 2 years ago

This PR contains two commits:

This reduces friction while working on the dcmjs code because all files are already formatted by Prettier which means you don't run into situations where you open a file, press save on a small edit, and have lots of other unrelated things change in the file due to prettier not having been run consistently.

One downside here is if merged it might cause conflicts with other PRs, although they should be easily addressed if that's the case.

Thoughts?

pieper commented 2 years ago

This sounds good to me, but I agree there's an impact on existing PRs. Anyone else have an opinion here? @swederik @sedghi @Punzo ?

sedghi commented 2 years ago

I don't have an open PR, but there is always an open PR, and the person can rebase IMO

Punzo commented 2 years ago

No issue on my side.