search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
292 stars 111 forks source link

fix: use metadataProvider option instead of cornerstone.metaData #280

Closed Punzo closed 2 years ago

pieper commented 2 years ago

@Punzo do you know why the test check is failing? Also I had thought @swederik turned off circleci - but it looks like we are still expecting it here?

Punzo commented 2 years ago

@Punzo do you know why the test check is failing? Also I had thought @swederik turned off circleci - but it looks like we are still expecting it here?

not sure, locally the tests are all green. It looks like the npm install step failed: image

is it possible for you to rerun it? I don't have the permissions for it.

pieper commented 2 years ago

Thank you Davide, yes, it must have been a glitch since it worked the second time.

I found these notes and have turned off circleci check requirement before merging.
https://circleci.com/docs2/2.0/enable-checks

Hopefully it will take effect for future PRs but for now I'll bypass the check and merge.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 0.22.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: