search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
292 stars 111 forks source link

move "eslint-config-prettier" to devDependencies #288

Closed florianlink closed 2 years ago

florianlink commented 2 years ago

It is wrong to list "eslint-config-prettier" as runtime "dependency", it needs to be a "devDependency". Having it as runtime dependencies introduces a large amount of licenses that the license checker will detect, which are not actually part of the deployed runtime of dcmjs.

swederik commented 2 years ago

Thanks! Can you run npm install so the package-lock file is updated as well?

florianlink commented 2 years ago

Yes, I added the lock file as well. By the way, a lot of dev dependencies report that they are outdated/deprecated, probably it would make sense to upgrade to newer versions of rollup etc.

florianlink commented 2 years ago

Can you merge this, please?

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 0.24.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: