search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
292 stars 111 forks source link

added support for specific character set #291

Closed florianlink closed 2 years ago

florianlink commented 2 years ago

refactored VR classes refactored reading/writing ascii and encoded strings changed hex writing to direct uint8 writing reimplemented null padded read removed unused code unified test data loading and cache the test data locally for faster test runs

this fixes: https://github.com/dcmjs-org/dcmjs/issues/84

florianlink commented 2 years ago

Looks like some tests have been added after my fork, I will merge them into my branch and port them as well. By the way, all these log.error("Invalid vr type " + type + " - using OW"); etc. make it hard to read the real errors. Maybe we could tackle that issue as well? Many of the example datasets cause these error logs (already before my changes).

pieper commented 2 years ago

Yes, thank you @florianlink 👍 I agree the log.error messages add a lot of noise. The testing framework has been evolving lately and any suggested fixes would be very welcome.

florianlink commented 2 years ago

I fixed the failing test, I overlooked one test case and it worked because of the previously downloaded file on my machine.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 0.24.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: