fix: support a charset of "ISO_IR 6", and throw errors for unsupported encodings

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation

https://dcmjs.netlify.com/

MIT License

291 stars 110 forks source link

fix: support a charset of "ISO_IR 6", and throw errors for unsupported encodings #298

Closed richard-viney closed 2 years ago

richard-viney commented 2 years ago

This PR makes two changes:

Make ISO_IR 6 value for SpecificCharacterEncoding not console.warn() about an unsupported encoding.
If the SpecificCharacterEncoding in a DICOM isn't supported by Node.js'TextDecoder then the error is now propagated and reading the DICOM will fail. The reason is that swallowing errors from unsupported encodings and proceeding seems like a dangerous/undesirable thing to do.

richard-viney commented 2 years ago

Upon closer inspection there were some bigger problems with character set handling which are addressed in #299. Am closing this PR in favour of that one.