fix: several issues with character set handling

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation

https://dcmjs.netlify.com/

MIT License

291 stars 110 forks source link

fix: several issues with character set handling #299

Closed richard-viney closed 2 years ago

richard-viney commented 2 years ago

Fix several character sets not working, e.g. "ISO_IR 13" and "ISO_IR 166"
Fix warning being shown when the "ISO_IR 6" character set is used
Add tests for reading encoded string data in several different character sets
Throw exception on an unsupported character set or multiple character sets rather than logging and continuing on (this can be overridden by setting ignoreErrors)

The new encodingMapping was based on code in pydicom as well as the DICOM spec.

pieper commented 2 years ago

This is looking good - thanks for the contribution 👍

Let me know when it's ready to merge.

richard-viney commented 2 years ago

The only additional change I think is warranted is to throw an exception on an attempt to use multiple character sets, because this isn't currently supported.

If ignoreErrors is set to true we would allow parsing to proceed and emit a warning similar to the existing one.

Seem reasonable?

richard-viney commented 2 years ago

I've added the changes to throw an exception on multiple character sets as well.

Setting ignoreErrors to true will allow the code to proceed past any character set issue.

richard-viney commented 2 years ago

Good to merge now 👍

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 0.24.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: