Closed richard-viney closed 2 years ago
This is looking good - thanks for the contribution 👍
Let me know when it's ready to merge.
The only additional change I think is warranted is to throw an exception on an attempt to use multiple character sets, because this isn't currently supported.
If ignoreErrors is set to true we would allow parsing to proceed and emit a warning similar to the existing one.
Seem reasonable?
I've added the changes to throw an exception on multiple character sets as well.
Setting ignoreErrors
to true will allow the code to proceed past any character set issue.
Good to merge now 👍
:tada: This PR is included in version 0.24.8 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
The new
encodingMapping
was based on code inpydicom
as well as the DICOM spec.