feat(anonymizer) - export Array tagNamesToEmpty and modify cleanTags

[juliencastelneau]

• export Array tagNamesToEmpty => Modify (add or remove) values before calling cleanTags

• add dict as parameter to function cleanTags => Choose which tags you want to modify for de-identification For instance, a call to anonymizer should be:

             const { cleanTags, tagNamesToEmpty } = dcmjs.anonymizer;
  
              var tagsToReplace = {
                  "00100010":   "ANON^PATIENT",
                  "00100020":   "ANON^ID"
              }
              var seriesDescription = "SeriesDescription";
              if (tagNamesToEmpty.indexOf(seriesDescription) != -1) {
                  tagNamesToEmpty.splice(tagNamesToEmpty.indexOf(seriesDescription), 1);
              } 
              var studyDescription = "StudyDescription";
              if (tagNamesToEmpty.indexOf(studyDescription) == -1) {
                  tagNamesToEmpty.push(studyDescription);
              } 
  
              cleanTags(dicomDict.dict, tagsToReplace);

[juliencastelneau]

Hello, Is there an issue with the PR ? @pieper I made the changes you requested. Maybe I do not understand something. Do you want another modification ? thx

[pieper]

Thanks for the contribution and the reminder 👍

[pieper]

@juliencastelneau it looks like there's at least one error due to the anonymizer - could you have a look?

https://github.com/dcmjs-org/dcmjs/actions/runs/3047634658/jobs/4911834982#step:5:2486

[juliencastelneau]

The test fails because I added an argument to the method cleanTags I think there are 2 ways to solve.

1. Modify the test:

Add the lines below in anonymizer.test.js (line 26)

    var tagsToReplace = {
        "00100010":   "ANON^PATIENT",
    }

    // when
    cleanTags(dicomDict.dict, tagsToReplace);

instead of

    cleanTags(dicomDict.dict);

2. Modify the method cleanTags to ensure the behaviour is unchanged:

export function cleanTags(
    dict,
    tagNamesToReplace = undefined,
    customTagNamesToEmpty = undefined
) {

    if (tagNamesToReplace==undefined) {
         tagNamesToReplace = {
            "00100010":   "ANON^PATIENT",
            "00100020":   "ANON^ID"
         }
    }

    var tags =
        customTagNamesToEmpty != undefined
            ? customTagNamesToEmpty
            : tagNamesToEmpty;

@pieper The best way is to modify the method cleanTags I guess. Do I need to make a new PR ?

[pieper]

Thanks for looking into this. I think the second option is better since it maintains backwards compatibility for the API. We should also add a new test demonstrating the ways to use the method and confirm it keeps working.

Yes, a new PR would be great since this has already been merged.