search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
291 stars 110 forks source link

SR support with Cornerstone 3D - multi-frame DICOM files #318

Open md-prog opened 1 year ago

md-prog commented 1 year ago

When saving an SR onto a multi-frame DICOM file, the frame number information are not being saved at all.

The reason is that dcmjs tries to detect multi-frame feature of a DICOM file, purely by sopClassID, and as we don't have all possible sopClassIDs in the comparison routine, measurement SRs are not working properly with many multi-frame DICOM files.

https://github.com/dcmjs-org/dcmjs/blob/914b3dccd1a9e9fd19f2ac94be6e02a82a6316ec/src/adapters/Cornerstone3D/MeasurementReport.js#L289

https://github.com/dcmjs-org/dcmjs/blob/914b3dccd1a9e9fd19f2ac94be6e02a82a6316ec/src/normalizers.js#L56

pieper commented 1 year ago

Thanks for reporting. Yes, adding all multiframe SOPClasses to the list would be good.