Open bmoix opened 1 year ago
Thanks for the report and the proposed fix 👍
Question though: shouldn't the VR be US or OW?
https://dicom.innolitics.com/ciods/nm-image/voi-lut/00283010/00283006
Thanks for taking the time to review this @pieper
Yes, you are right!
In the case that a tag can have more than one VR, what is the best approach? Is using the first one that appears in the tag definition, US in this particular case, good enough? I can see that in dictionary.js
you can only assign one VR for each tag.
Update the Value Representation (VR) for the LUTData tag. It was defined as
lt
instead ofLT
.The method
ValueRepresentation.createByTypeString(type)
fromValueRepresentation.js
couldn't find the right VR class from theVRInstances
object, and it was creating anUnknownValue
object. This was causing a crash when reading a file with that tag.Context
Tests
All unit tests pass :heavy_check_mark: