dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
287 stars 108 forks source link

change the export style in dicom.js to ES6. #350

Closed IbrahimCSAE closed 1 year ago

IbrahimCSAE commented 1 year ago

https://github.com/dcmjs-org/dcmjs/pull/348

I saw this issue in a recent pull request, and I believe It's happening because of using module.exports then trying to import using ES6 syntax in Tag.js. To fix this issue, I believe we can change the export style in dicom.js to ES6.

I did this and I tried running the build command, I didn't get any errors from rollup.