search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
287 stars 108 forks source link

private Tags take element wrong into account #356

Open lmdulz opened 1 year ago

lmdulz commented 1 year ago

why does the isPrivateCreator function of the Tag Class check if the element is bigger than 0x00? that is not a requirement according to the dicom standard? But its actually a requirement for it not to be between 0001-000F

pieper commented 1 year ago

Thanks for reporting 👍

For background, when you report an issue, it helps to include a link to the code you are referring too (e.g. like this.

You can also use the "blame" feature of git to get a link to the commit that added the feature (like this).

This commit includes links to the original issues addressed and discussion about the corresponding PR. Here https://github.com/dcmjs-org/dcmjs/issues/242 and https://github.com/dcmjs-org/dcmjs/pull/243

Can you have a look at these and ideally propose code changes along with sample data and tests, along with a description of why the change is needed to manage any issues you are seeing. Ideally also including comparisons to how other toolkits manage the data.

We are trying to be very careful with changes to this code as we want to avoid regressions.