search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
294 stars 112 forks source link

Fixed issue with Decimal String conversion resulting in more than 16 … #367

Closed rvantklooster closed 1 year ago

rvantklooster commented 1 year ago

Fixed issue with Decimal String conversion resulting in more than 16 characters and added unit test. See https://github.com/dcmjs-org/dcmjs/issues/366

swederik commented 1 year ago

Yes completely agree, the code is good but a short comment about why it exists will be helpful for the next person who reads it. Especially happy that @rvantklooster added a test! Thanks!

rvantklooster commented 1 year ago

I updated the documentation (in line with the documentation of its pydicom counterpart). Nice to see this quick turnaround!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 0.29.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket: