search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
287 stars 108 forks source link

fix: 🐛 Check that VR has accessors for natural types (#368) #369

Closed dmlambo closed 8 months ago

dmlambo commented 8 months ago

When naturalizing a dataset, the ValueRepresentation class used to add accessors may be ambiguous if the tag has multiple VR types. In this case we fall back to no accessor. There are only a handful of tags that fall into this category, and currently only PN has an accessor.

Specifically, this fixes the plethora of errors in OHIF stating ValueRepresentation.js:262 Invalid vr type xs - using US

github-actions[bot] commented 8 months ago

:tada: This PR is included in version 0.29.12 :tada:

The release is available on:

Your semantic-release bot :package::rocket: