search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
287 stars 108 forks source link

Update package version to 0.32.0 #385

Closed ahlaughland closed 2 months ago

ahlaughland commented 3 months ago

I missed this small detail when submitting my PR.

ahlaughland commented 3 months ago

Updated to be 0.32.0 since this PR will update the latest package to v0.32.0

pieper commented 3 months ago

We haven't been consistent on this version number, rather relying on the semantic commit approach that updates the npm package versions. Seems like people just update now-and-then.

@ahlaughland If you know or can find out the correct policy for how this number should be managed it would be great to add a note to the readme so we can be consistent going forward. Thanks 👍

ahlaughland commented 3 months ago

We haven't been consistent on this version number, rather relying on the semantic commit approach that updates the npm package versions. Seems like people just update now-and-then.

@ahlaughland If you know or can find out the correct policy for how this number should be managed it would be great to add a note to the readme so we can be consistent going forward. Thanks 👍

I will take a look and see what I can do. Thanks again!

ahlaughland commented 2 months ago

@pieper I looked at a few repos and the version in package.json is typically updated as part of the PR. This is how we do it but mostly not. 😄

OHIF for example, removed version from their package.json and moved it to a version.json file, which they edit with the latest version update - https://github.com/rapidllc/3drd-ohif-v3/blob/main/version.json.

The only recommendation I could make is to manually update version in the DCMJS package.json as part of PR approvals. Other than that the process looks good.