search

dcmjs-org / dcmjs

Javascript implementation of DICOM manipulation
https://dcmjs.netlify.com/
MIT License
287 stars 108 forks source link

feat: Netlify app master-dcmjs2 deploy build #392

Closed wayfarer3130 closed 2 months ago

wayfarer3130 commented 2 months ago

The change uses the URL that built correctly on the last deploy of dcmjs. Looks like it should work this time.

netlify[bot] commented 2 months ago

Deploy Preview for dcmjs2 ready!

Name Link
Latest commit 190b70fd45783a9f513abb4c6acd69464acea4c1
Latest deploy log https://app.netlify.com/sites/dcmjs2/deploys/66393d36c81c0100094f18e8
Deploy Preview https://deploy-preview-392--dcmjs2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

wayfarer3130 commented 2 months ago

@pieper - the last build actually worked for deployment, against: https://master--dcmjs2.netlify.app Those examples are live, albeit we are still seeing issues with CORS to the lury back end - I'm not sure who set that data up, if you know if they could update those to allow the examples to actually run that would be good.

pieper commented 2 months ago

Thanks @wayfarer3130 - I'm not sure what 'lury' refers to, but it seems to be something @swederik and @JamesAPetts added so maybe they know?

https://github.com/dcmjs-org/dcmjs/commit/0e1e2921e953bde8f4707b025f584a6c558ffedd

The vtk.js / dicom seg example uses some data of me from IsomicsPublic bucket and the CORS is set correctly there, but there's been some change in dicomweb-client that breaks the ArrayBuffer parsing (it's now an Array with one ArrayBuffer element, where the code is expecting an ArrayBuffer directly - I'm not sure when that behavior came in but it should be easy to fix). I guess now I can just test a fix with the web editor and test it using the netlfy preview - cool!

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 0.32.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

wayfarer3130 commented 2 months ago

@pieper - had to fix a race condition on the download as well so that the failing test now passes consistently.

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 0.33.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: