search

dcmoura / spyql

Query data on the command line with SQL-like SELECTs powered by Python expressions
https://spyql.readthedocs.io
MIT License
918 stars 25 forks source link

Code improvements #60

Closed dcmoura closed 1 year ago

dcmoura commented 2 years ago

Some cases where the code could be more pythonic:

Changes should be accessed for performance.

dcmoura commented 2 years ago

Also check flake8 warnings

Hayashi-Yudai commented 2 years ago

May I do it?

dcmoura commented 2 years ago

Yes, go for it! This is is great for first time contributors. Check the CONTRIBUTING file to understand how to setup the dev environment and start by running the tests before making any change. Once you are good, you may start changing the code while making sure that tests continue passing. Let me know if you have any question. Thank you!

Hayashi-Yudai commented 2 years ago

@dcmoura

I have a question.

some functions where yield might be used to return a generator

What does this refer to? Are there functions which return large list?

dcmoura commented 2 years ago

When I started coding SPyQL there were some Python patterns that I was not familiar with. Mainly the use of a) yield and b) enumerate. The ideia is to try to understand where the use of such patterns can help making the code cleaner and/or increase performance. This does not need to be exhaustive. @Hayashi-Yudai

dcmoura commented 1 year ago

Closed by #82