dcmoura / spyql

Query data on the command line with SQL-like SELECTs powered by Python expressions
https://spyql.readthedocs.io
MIT License
918 stars 25 forks source link

code improvement for issue #60 #82

Closed Hayashi-Yudai closed 1 year ago

Hayashi-Yudai commented 2 years ago

Improve the code.

TODOs

Issue: https://github.com/dcmoura/spyql/issues/60

codecov[bot] commented 2 years ago

Codecov Report

Base: 95.63% // Head: 95.62% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (f1132ca) compared to base (8445350). Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #82 +/- ## ========================================== - Coverage 95.63% 95.62% -0.02% ========================================== Files 15 15 Lines 1284 1279 -5 ========================================== - Hits 1228 1223 -5 Misses 56 56 ``` | [Impacted Files](https://codecov.io/gh/dcmoura/spyql/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura) | Coverage Δ | | |---|---|---| | [spyql/processor.py](https://codecov.io/gh/dcmoura/spyql/pull/82/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura#diff-c3B5cWwvcHJvY2Vzc29yLnB5) | `95.81% <80.55%> (-0.03%)` | :arrow_down: | | [spyql/parser.py](https://codecov.io/gh/dcmoura/spyql/pull/82/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura#diff-c3B5cWwvcGFyc2VyLnB5) | `99.46% <88.88%> (-0.01%)` | :arrow_down: | | [spyql/cli.py](https://codecov.io/gh/dcmoura/spyql/pull/82/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura#diff-c3B5cWwvY2xpLnB5) | `95.83% <100.00%> (ø)` | | | [spyql/qdict.py](https://codecov.io/gh/dcmoura/spyql/pull/82/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura#diff-c3B5cWwvcWRpY3QucHk=) | `94.23% <100.00%> (ø)` | | | [spyql/query.py](https://codecov.io/gh/dcmoura/spyql/pull/82/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura#diff-c3B5cWwvcXVlcnkucHk=) | `97.95% <100.00%> (ø)` | | | [spyql/sqlfuncs.py](https://codecov.io/gh/dcmoura/spyql/pull/82/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura#diff-c3B5cWwvc3FsZnVuY3MucHk=) | `93.18% <100.00%> (-0.16%)` | :arrow_down: | | [spyql/utils.py](https://codecov.io/gh/dcmoura/spyql/pull/82/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura#diff-c3B5cWwvdXRpbHMucHk=) | `100.00% <100.00%> (ø)` | | | [spyql/writer.py](https://codecov.io/gh/dcmoura/spyql/pull/82/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura#diff-c3B5cWwvd3JpdGVyLnB5) | `94.08% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dcmoura commented 2 years ago

@Hayashi-Yudai Please assign me as reviewer when you are done. You can also add Diogo and Chaves. Thank you!

Hayashi-Yudai commented 2 years ago

@dcmoura I want, but I cannot assign anyone. Is there something I should do?

image
dcmoura commented 2 years ago

Typically, you would only open the PR when it is ready to review. Since you opened a WIP I would say that you could leave a comment when you are done.

Hayashi-Yudai commented 2 years ago

I see, thank you! Please review my code