Codecov Report

Base: 95.62% // Head: 95.62% // No change to project coverage :thumbsup:

Coverage data is based on head (bffee9a) compared to base (ca5b414). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #87 +/- ## ======================================= Coverage 95.62% 95.62% ======================================= Files 15 15 Lines 1279 1279 ======================================= Hits 1223 1223 Misses 56 56 ``` | [Impacted Files](https://codecov.io/gh/dcmoura/spyql/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura) | Coverage Δ | | |---|---|---| | [spyql/parser.py](https://codecov.io/gh/dcmoura/spyql/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura#diff-c3B5cWwvcGFyc2VyLnB5) | `99.46% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Moura)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Hayashi-Yudai commented 1 year ago

@dcmoura Please review my code! (I do not know why, but I cannot assign any reviewer this time either... I am grad if you assign reviewers, sorry.)

Hayashi-Yudai commented 1 year ago

@dcmoura @recharte @ricardocchaves I have corrected all the points you pointed out, so please review again.

Hayashi-Yudai commented 1 year ago

(Only one review request at a time...?)

dcmoura commented 1 year ago

(Only one review request at a time...?)

I can take this one :-)

Hayashi-Yudai commented 1 year ago

The implementation that you propose is simple and neat, but misses some cases that result in unexpected behaviour.

Oh....

a) you can fix the current implementation and re-request a review b) if you are tired of this ping-pong, I can merge the current implementation to a feature branch in spyql and finish the implementation myself

Thank you. I cannot know the cost to fix it for now, so I want to try and decide how to proceed. I consider one day and tell you what I want to do.

dcmoura commented 1 year ago

@Hayashi-Yudai can you please add me as contributor to your forked repo?

I would like to wrap-up this PR. I could do this by merging to a feature branch and make the last changes there (e.g. update documentation, minor code tweaks/comments), open another PR and then merge to master. However, if I do that I would be the author and you the co-author, and that is not fair. If I do the last changes on your forked repo, I could then merge directly to master, and since you opened the PR you would be the main author.

BTW, I already started making the final changes, so please do not make any new commits, your work is done :-)

Thanks!

Hayashi-Yudai commented 1 year ago

can you please add me as contributor to your forked repo?

OK, I sent you an invitation.

dcmoura commented 1 year ago

Closes #84 Closes #85

dcmoura / spyql

Refactor `parse_structure` and allow comment in query #87

Codecov Report