Add started at - Githubissues

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests

https://github.com/apps/dco

ISC License

299 stars 75 forks source link

Add started at #100

Closed jsoref closed 5 years ago

jsoref commented 5 years ago

This prevents GitHub from reporting: DCO Successful in -1m

jsoref commented 5 years ago

See probot/probot#803

jsoref commented 5 years ago

@hiimbex : updated...

jsoref commented 5 years ago

@hiimbex : do you need something more from me?

jsoref commented 5 years ago

So, something looks wrong:

Note: 712m is imo slightly better than -1m, but I can't imagine DCO taking that long to run...

hiimbex commented 5 years ago

lol ok I didn't think this through. If we define it in the app, it's like a massive global - like when the app starts or is redeployed. For it to actually happen on a per run basis, it needs to be in the webhook trigger declaration (so like app.on). Wanna open a follow up PR for thst @jsoref?

jsoref commented 5 years ago

Sure

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: